[LTP] [RFC PATCH v4 4/4] tst_test.sh: Add TST_TEST_DATA and TST_TEST_DATA_IFS

Petr Vorel pvorel@suse.cz
Fri May 25 17:53:31 CEST 2018


Hi Cyril,

> > > > +_tst_run_tests()
> > > > +{
> > > > +	local data="$1"
> > > > +	local i

> > > Shouldn't we prefix these two variables with _tst_ prefix as well?
> > IMHO no, as _tst_run_test and _tst_run_tests is private and these variables are local.
> > I thought we need to change tst_run as it's run by the tests and all variables which are.

> As far as I can tell these still leak into the fnc function, or am I
> mistaken?

Uh, you're right. I didn't know that sourcing will absorb local function data outside of
function :(. I'll fix it in v5.


Kind regards,
Petr


More information about the ltp mailing list