[LTP] [PATCH] kernel/syscall/setrlimit05.c: use a legal bad address for mips

Cyril Hrubis chrubis@suse.cz
Mon Nov 5 16:22:37 CET 2018


Hi!
> diff --git a/testcases/kernel/syscalls/setrlimit/setrlimit05.c b/testcases/kernel/syscalls/setrlimit/setrlimit05.c
> index e716722..57b0b82 100644
> --- a/testcases/kernel/syscalls/setrlimit/setrlimit05.c
> +++ b/testcases/kernel/syscalls/setrlimit/setrlimit05.c
> @@ -31,9 +31,13 @@ static void verify_setrlimit(void)
>  	int status;
>  	pid_t pid;
>  
> +    void *bad_addr;
> +
> +    bad_addr = tst_get_bad_addr(NULL);

It would be better if we called this only once in the test setup()
function as the function actually maps a page of memory, the test may
fail if we pass large enough -i parameter.

>  	pid = SAFE_FORK();
>  	if (!pid) {
> -		TEST(setrlimit(RLIMIT_NOFILE, (void *) -1));
> +		TEST(setrlimit(RLIMIT_NOFILE,(struct rlimit *)bad_addr));
>  		if (TST_RET != -1) {
>  			tst_res(TFAIL, "setrlimit()  succeeded unexpectedly");
>  			exit(0);
> -- 
> 2.8.1
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list