[LTP] [PATCH 4/6] network/mpls02: new test with lwtunnel

[Alexey Kodanev]

Hi Petr,

On 11/02/2018 11:02 PM, Petr Vorel wrote:
> Hi,
> 
>> Setup MPLS encapsulation over the default test network setup,
>> use ICMP, UDP and TCP inner protocols.
> 
>> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
>> ---
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Just some minor things bellow.
> 
>> +TST_MIN_KVER="4.3"
>> +TST_NEEDS_TMPDIR=1
>> +TST_NEEDS_ROOT=1
>> +TST_NEEDS_DRIVERS="mpls_router mpls_iptunnel"
> Here is missing mpls_gso
> 

Right.

> ...
>> +mpls_setup()
>> +{
>> +	local label="$1"
>> +
>> +	ROD modprobe mpls_router
>> +	ROD modprobe mpls_iptunnel
>> +	ROD modprobe mpls_gso
> Maybe just?
> ROD modprobe mpls_gso $TST_NEEDS_DRIVERS


OK, and it will need the '-a' option.

> 
>> +	ROD sysctl -q net.mpls.conf.$(tst_iface).input=1
>> +	ROD sysctl -q net.mpls.conf.lo.input=1
> This one can be set with tst_set_sysctl, as it's the same for both lhost and
> rhost.
>> +	ROD sysctl -q net.mpls.platform_labels=$label
> The same is for this one ...
>> +	rpf_loc="$(sysctl -n net.ipv4.conf.all.rp_filter)"
>> +	ROD sysctl -q net.ipv4.conf.all.rp_filter=2
> ... and this one.
> 

Indeed, I almost forgot that we have such a function helper in
the library, thanks!

>> +	tst_rhost_run -s -c "modprobe mpls_router"
>> +	tst_rhost_run -s -c "modprobe mpls_iptunnel"
>> +	tst_rhost_run -s -c "modprobe mpls_gso"
> tst_rhost_run -s -c "modprobe $TST_NEEDS_DRIVERS"
> 
>> +	tst_rhost_run -s -c "sysctl -q net.mpls.conf.$(tst_iface rhost).input=1"
>> +	tst_rhost_run -s -c "sysctl -q net.mpls.conf.lo.input=1"
>> +	tst_rhost_run -s -c "sysctl -q net.mpls.platform_labels=$label"
>> +	rpf_rmt="$(tst_rhost_run -c 'sysctl -n net.ipv4.conf.all.rp_filter')"
>> +	tst_rhost_run -s -c "sysctl -q net.ipv4.conf.all.rp_filter=2"
>> +}
> 
> 
> Kind regards,
> Petr
>