[LTP] [PATCH 2/2] syscalls/chmod05: Use new ltp library
Tue Nov 6 18:01:21 CET 2018
On Tue, Nov 06, 2018 at 05:33:05PM +0100, Cyril Hrubis wrote:
> > This was added, but I don't think it hurts anything, if at all it resets what
> > the test does in the setup (even though its probably not needed)?. I'll leave
> > it upto you to keep / delete this.
> I've removed the cleanup and did a few minor changes as well and pushed,
> * Deleted /* stat struct */ and other comments commenting obvious
> * Added return; in the if (TST_RET == -1) statement, there is no point
> in checking the directory permissions if the call has failed
> * Removed spaces before tabs in the tst_test structure
That was done to align the fields, I will be more mindful next time.
Thanks for making the changes.
> Cyril Hrubis
More information about the ltp