[LTP] [PATCH v4] Testing statx syscall Timestamp fields
Thu Nov 15 10:46:06 CET 2018
> >> + rval = clock_getres(clk_id, res);
> >> + if (rval == -1)
> > ^
> > rval != 0 is a bit more robust
> >> + tst_brk(TBROK | TERRNO,
> >> + "%s:%d:, clock_getres() failed", file, lineno);
> > ^ ^
> > | We should print the
> > parameters here
> > No comma here please.
> >> +
> >> +}
> >> +
> Since file and lineno are error indicating parameters and not the actual
> function arguments we preferred printing it before the actual error
Well the clk_id could be computed on the fly and passed to the function,
hence it would be better to print it here.
> Also as the second parameter is a structure we weren't sure if it is
> necessary to print individual structure members. That is why we preferred
> printing a plain error message with just the lineno and file name.
We usually print structure pointers passed just as %p. There is no point
in printing out the structure members here becaues if the call fails the
structure will not be initialized and will likely contain random
> > Again do we really need 512MB for the test?
> > I doubt so.
> >> + .mnt_flags = MS_STRICTATIME,
> >> +};
> > Otherwise it's good.
> > --
> > Cyril Hrubis
> > email@example.com
> For the ext4 to provide nanosecond precision to the timestamp fields the
> INODE size has to be atleast 256bytes.
> If the file system size is smaller than 512MB then by default the INODE
> size will be only 128bytes and hence will not support birth time and nano
> second precision.
Here we are assuming something that may change in the future, shouldn't
we rather pass "-I 256" to the mkfs the same way we pass "-b $PAGESIZE"
in statx05.c? Then we can go with whatever the default filesystem size
More information about the ltp