[LTP] [PATCH v4 1/2] net: Add tst_net_run helper

Petr Vorel pvorel@suse.cz
Mon Nov 19 16:40:04 CET 2018

Hi Alexey,

> >>> Maybe we could signal where error occurred:
> >>> * return 0: ok on both lhost and rhost
> >>> * return 1: failure on lhost
> >>> * return 2: failure on rhost
> >>> * return 3: failure on both lhost and rhost

> >> It is only when there is no "safe" option, right?
> > yes, as safe exit with TCONF and warning.

> >> when doing cleanup?
> > IMHO in any "non-safe" run.

> >> Could we print TWARN message inside tst_net_run() in such case?
> > I wanted tst_net_run() to behave similarly as tst_rhost_run(), which doesn't
> > warn about it. So I propose to add warning to both functions, but also add -q
> > flag (quiet), which suppress this warning.

> I think we don't need it for tst_rhost_run() as it is clear where the
> error has happened. Unlike tst_net_run() without safe option.
OK, make sense, I'll put it just into tst_net_run().

> > The reason for quiet mode is, that (I suppose) there are cases when some
> > features is tested and TWARN isn't wanted. Some examples (looks -s is used often
> > in cleanup functions):

> '-s' is used often in cleanup with tst_rhost_run()?
Sorry, I was wrong. Previously I meant tst_rhost_run *without -s* option.

tst_rhost_run with -s option in cleanup is only in 2 files:
Maybe that's a mistake (unlike C functions where error in SAFE_* continue with
warning, in shell it exits during cleanup).

Without -s we don't get any warning, which is often desirable.
=> I'll put warning and -q switch to suppress it only into tst_net_run().

Kind regards,

More information about the ltp mailing list