[LTP] [RFC PATCH 4/5] runtest/commands: adjust names for keyctl01, sysctl01, unshare01

Stanislav Kholmanskikh stanislav.kholmanskikh@oracle.com
Mon Oct 8 11:01:56 CEST 2018


Hi

On 10/03/2018 10:42 AM, Cyril Hrubis wrote:
> Hi!
>> As if
>>
>> keyctl01 keyctl01.sh
>>
>> was changed to
>>
>> keyctl01_sh keyctl01.sh
>>
>> Correct?
> 
> Or we can, for the cases where command has the same name as syscall,
> increment the numbers for the command tests by 50, that should avoid the
> collisions.
> 
> So the keyctl01.sh will become keyctl51.sh.
> 

Maybe we better stick to your previous proposal, i.e. adding _sh to the
end of a name (in runtest files)? In my opinion, it's more clear and
straightforward, i.e. if one has a look at a runtest file, it will take
little time to understand why some tests have _sh at the end. Plus it
doesn't require renaming of the sh test cases.

Shifting the numbering by a big number looks a bit tricky.


More information about the ltp mailing list