[LTP] [PATCH 1/1] syscalls/statx04: TCONF on BTRFS for kernel < 4.13

Petr Vorel pvorel@suse.cz
Mon Oct 8 14:09:40 CEST 2018


Hi Cyril,

> Why not just:

> 	if (!strcmp(tst_device->fs_type, "btrfs") && tst_kvercmp(4, 13, 0) < 0)
> 		tst_brk(TCONF, "Btrfs statx() supported since 4.13");


> There is no point in parsing a statically defined string that will never
> change with tst_parse_kver().

Sure, make sense.
Thanks for pointing out silly code.
Pushed with your reviewed-by tag.

Kind regards,
Petr


More information about the ltp mailing list