[LTP] [PATCH 1/6] lapi: Add TEMP_FAILURE_RETRY definition

Petr Vorel pvorel@suse.cz
Fri Oct 19 16:57:31 CEST 2018


Hi Cyril,

> Hi!
> > and use it in realtime to fix pi-tests.
> > This fixes build failure on libc missing it (e.g. musl, bionic):

> > test-skeleton.c:112:12: warning: implicit declaration of function ???TEMP_FAILURE_RETRY??? [-Wimplicit-function-declaration]
> >   termpid = TEMP_FAILURE_RETRY(waitpid(pid, &status, 0));
> >             ^~~~~~~~~~~~~~~~~~
> > make[5]: *** [<builtin>: testpi-6] Error 1

> I had no idea glibc has macro like this. I do wonder if it worth a
> fallback definition if we have exactly one use in the source code tree.
> Maybe we should just replace the macro with the while loop instead.

Replaced and the rest pushed with your ack.
Thanks for your review!


Kind regards,
Petr


More information about the ltp mailing list