[LTP] [RFC PATCH 1/4] syscalls/abort01: convert to new library

Sandeep Patil sspatil@android.com
Wed Apr 3 17:49:31 CEST 2019


On Wed, Apr 03, 2019 at 02:06:53PM +0200, Cyril Hrubis wrote:
> Hi!
> > > > I am surprised that didn't throw a warning + build error for me.
> > > > other than that, thanks for doing this
> > > 
> > > That depends on gcc version and mix of warning flags...
> > 
> > clang actually throws a lot of warnings for us when we build it natively for
> > Android. In this case however, I just used my laptop "gcc (Debian 7.3.0-5)"
> > and default flags for LTP builds.
> > 
> > Do you have plans of enabling -Werror?
> 
> We cannot do that with the amount of legacy code we have the build would
> fail pretty much every time. So no, no plans for the foreseeable future.

Ack, thanks Cyril. I'd rather convert as many tests to the new library before
I get to them then. By the way, I sent V2s for acct01 & accept01 addressing
your comments now.

- ssp


More information about the ltp mailing list