[LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations

[Xiao Yang]

On 2019/04/05 15:13, Petr Vorel wrote:
> Hi Xiao, Cyril,
>
>> Thanks for your comment.
>> I will send v2 patch as you suggested. :-)
> v2 has LTP_CHECK_LIBC_FUNCS in m4/ltp-libc-funcs.m4.
> IMHO it'd be better to have simple AC_CHECK_FUNCS() in configure.ac, i.e. the
> same way we handle AC_CHECK_HEADERS(). It might not be good to mix configure.ac
> and m4/ltp-*.m4, but I guess general functions like this is easier to find in
> configure.ac than in some of m4/ltp-*.m4.
Hi Petr,

Sorry, I missed your last comment.
It seems easier to remove LTP_CHECK_LIBC_FUNCS directly.

I will send v3 patch soon.

Best Regards,
Xiao Yang
>
> Kind regards,
> Petr
>
>> Best Regards,
>> Xiao Yang
>> On 2019/04/04 19:58, Petr Vorel wrote:
>>> Hi,
>>>>> Note about formatting: maybe it'd be easier to edit the file if each function
>>>>> was on separate line.
>>>> Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
>>>> step would be moving these there as well.
>>> +1 (easier to find general things like this in configure.ac than in m4/ltp-*.m4.
>>>> Other than that this is a great cleanup, thanks for doing this.
>>> Kind regards,
>>> Petr
>
>
>
>
>
>
>
>