[LTP] [PATCH v3 3/3] syscalls/sigpending02.c: Add libc sigpending() detection && reset sighandler_counter

Petr Vorel pvorel@suse.cz
Fri Apr 5 11:06:20 CEST 2019


Hi Xiao,

whole patchset LGTM.
...
> +++ b/testcases/kernel/syscalls/sigpending/sigpending02.c
> @@ -13,6 +13,7 @@
>   * Test 2: Call sigpending(sigset_t*=-1), it should return -1 with errno EFAULT.
>   */

> +#include "config.h"
>  #include "tst_test.h"
>  #include "ltp_signal.h"
>  #include "lapi/syscalls.h"
> @@ -36,7 +37,12 @@ static int tested_sigpending(sigset_t *sigset)
>  {
>  	switch (tst_variant) {
>  	case 0:
> +#ifndef HAVE_SIGPENDING
> +		tst_brk(TCONF, "libc sigpending() is not implemented");
> +#else
>  		return sigpending(sigset);
> +#endif
> +		break;
very minor nit: shift left break (to be on the same level as case).

>  	case 1:
>  		return tst_syscall(__NR_sigpending, sigset);
>  	case 2:

Kind regards,
Petr


More information about the ltp mailing list