[LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace definition ANDROID with __ANDROID__

Petr Vorel pvorel@suse.cz
Sun Apr 14 12:11:59 CEST 2019


Hi Sandeep, Zhengwang,

> On Fri, Apr 12, 2019 at 11:36:46PM +0800, 阮正旺 wrote:
> > Hi Petr, Sandeep, Steve,


> > -------- Original Message --------
> > From: Petr Vorel
> > Sent: Thu, 11 Apr 2019 19:46:38 +0200
> > To: Zhengwang Ruan, Steve Muckle, Sandeep Patil
> > Cc: Ltp
> > Subject: Re: [LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace definition
> > ANDROID with __ANDROID__
> > > Hi,

> > > > Replace the incorrect definition of ANDROID with __ANDROID__.
> > > > +++ b/testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c
> > > > @@ -25,7 +25,7 @@
> > > >   #include "tst_test.h"
> > > >   #include "lapi/syscalls.h"
> > > > -#ifndef ANDROID
> > > > +#ifndef __ANDROID__
> > > Simple grep in AOSP tree would be for this change (and I'd personally prefer it as well)
> > > I'd kindly ask android devs which one is correct :). BTW ANDROID was added by Steve.

> > According to also [1], this patch is acceptable, right?

> Yes, indeed.

> Acked-by: Sandeep Patil <sspatil@android.com>

Thanks for your review.
Merged (with slightly changed commit message) + I made this change in
include/tst_safe_posix_ipc.h in a separate commit.


Kind regards,
Petr


More information about the ltp mailing list