[LTP] [PATCH 2/4] syscalls/fanotify13: new test to verify FAN_REPORT_FID functionality

[Amir Goldstein]

On Tue, Apr 16, 2019 at 4:41 PM Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> > Newly defined test file to validate the fanotify FAN_REPORT_FID
> > functionality.
> >
> > Signed-off-by: Matthew Bobrowski <mbobrowski@mbobrowski.org>
> > Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> > ---
> >  testcases/kernel/syscalls/fanotify/.gitignore   |   1 +
> >  testcases/kernel/syscalls/fanotify/fanotify.h   |  19 +-
> >  testcases/kernel/syscalls/fanotify/fanotify13.c | 329 ++++++++++++++++++++++++
>
> This is missing the runtest entry in runtest/syscalls so that the test
> is picked up by the testrunner.
>
> And the same bug slipped in during review for fanotify12 so I've
> commited a fix that adds it there.
>
> ...
>
> > +static void do_test(unsigned int number)
> > +{
> > +     unsigned int i;
> > +     int len, fds[ARRAY_SIZE(objects)];
> > +
> > +     struct file_handle *event_file_handle;
> > +     struct fanotify_event_metadata *metadata;
> > +     struct fanotify_event_info_fid *event_fid;
> > +     struct test_case_t *tc = &test_cases[number];
> > +     struct fanotify_mark_type *mark = &tc->mark;
> > +
> > +     tst_res(TINFO,
> > +             "Test #%d: FAN_REPORT_FID with mark flag: %s",
> > +             number, mark->name);
> > +
> > +     /* Gets the filesystem fsid and file handle for each object */
> > +     get_object_stats(tc);
>
> Is there a reason why are are not calling this function once in the test
> setup? It will be called for every test iteration when the test is
> passed the -i option...
>

I think that's an oversight. It could be called once during setup.

Thanks,
Amir.