[LTP] LTP Release

Petr Vorel pvorel@suse.cz
Mon Apr 29 22:45:27 CEST 2019


Hi Cyril,

> There are two things to fix. One that the patch from Jan attempted is
> wrong path in the rule in the testcases.mk and the second one is that
> the libraries are not build from the top level Makefile first before
> everything else.

> For the first problem fixing the path to the library Makefile should fix
> the problem, something as (beware untested) this should fix it:

> diff --git a/include/mk/testcases.mk b/include/mk/testcases.mk
> index 131854ec7..6d1b2d4ef 100644
> --- a/include/mk/testcases.mk
> +++ b/include/mk/testcases.mk
> @@ -49,7 +49,7 @@ LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach
>  MAKE_DEPS += $(LTPLIBS_FILES)

>  $(LTPLIBS_FILES): $(LTPLIBS_DIRS)
> -       $(MAKE) -C "$^" -f "$^/Makefile" all
> +       $(MAKE) -C "$^" -f "$(subst $(abs_top_buildir),$(abs_to_srcdir),$^)/Makefile" all

>  LDFLAGS += $(addprefix -L$(top_builddir)/libs/lib, $(LTPLIBS))

> I will have a look at the top level Makefile as well to see what has to
> be done there.
Tested-by: Petr Vorel <pvorel@suse.cz>

This one looks ok. Also testing with machine with 32 cores, ok as well (but it's
hard to trigger this bug even current master).

Kind regards,
Petr

[1] https://travis-ci.org/pevik/ltp/builds/526016709


More information about the ltp mailing list