[LTP] [PATCH] syscalls/swapon02: Do not fail on overlayfs

[Murphy Zhou]

On Tue, Apr 30, 2019 at 05:21:34PM +0800, Li Wang wrote:
> On Tue, Apr 30, 2019 at 5:08 PM Murphy Zhou <xzhou@redhat.com> wrote:
> 
> > ...
> > > > > > +       if (fs_type == TST_OVERLAYFS_MAGIC && errno == EINVAL) {
> > > > > > +               tst_resm(TCONF, "Swapfile on overlayfs not
> > > > implemeted");
> > > > > > +                       return;
> > > > > > +       }
> > > > > >
> > > > >
> > > > > The code looks correct.
> > > > >
> > > > > But it already has a test skipping for BTRFS, is there any
> > possibility to
> > > > > combine these filesystems check together?
> > > >
> > > > Good idea~  Sending V2.
> > > >
> > >
> > > One more comment.
> > >
> > > I just noticed that it also has an FS skipping list in setup(), do u
> > think
> > > can we move BTRFS and OVERLAYFS to there?
> >
> > Great! That makes perfect sense. Also I'm thinking a few other tweaks
> > needed:
> >
> >   NFS now actually support swapfiles. Let's remove it from skip list;
> >
> 
> But AFAIK someone still run LTP on old distro/kernel, so we can't guarantee
> the test works fine in that situation. So, my opinion is to reserve the
> NFS, or do you have a better way to make test more flexible?

Fair enough. We can reserve NFS on the skip list to avoid much false alarms.
> 
> 
> >   Skip all swapon/swapoff tests on TMPFS BTRFS OVERLAYFS;
> >   Add CIFS_MAGIC, then skip on it too;
> >   Remove existing BTRFS return value tweaks.
> >
> 
> Agree.

Thanks!

M
> 
> -- 
> Regards,
> Li Wang