[LTP] [PATCH v2] cve: Fix kernel symbol finding for meltdown case

Jan Stancek jstancek@redhat.com
Thu Aug 22 14:37:47 CEST 2019



----- Original Message -----
> 
> 
> ----- Original Message -----
> > From: He Zhe <zhe.he@windriver.com>
> > 
> > meltdown case fails as below.
> > safe_file_ops.c:219: BROK: Expected 3 conversions got 2 at meltdown.c:272
> > 
> > find_kernel_symbol is defined to try twice with each of /proc/kallsyms and
> > /boot/System.map-%s. Currently if the symbol is not found in
> > /proc/kallsyms,
> > when kernel option CONFIG_KALLSYMS_ALL is disabled, it would stop the case
> > immediately due to SAFE_FILE_LINES_SCANF.
> > 
> > This patch turns to use FILE_LINES_SCANF to give find_kernel_symbol second
> > chance.
> 
> That explains it, thanks for the patch.
> 
> We should also tweak TCONF condition in find_kernel_symbol - no need
> to re-post for that, I can add that.

Pushed, also with tweak for commit 7709d2ae92ea, so we try System.map,
even if kallsyms are completely disabled.

Regards,
Jan


More information about the ltp mailing list