[LTP] [PATCH v2 2/2] network/iptables: add new test for iptables-tranlsate and nft

Petr Vorel pvorel@suse.cz
Thu Dec 19 08:08:45 CET 2019


Hi Alexey,

> > BTW even more setup could be moved into iptables_lib.sh.
> > If you like this change, I can push it.

> No objections. I thought it is better to keep these TST_*
> variables per test, in the header, rather than searching
> in the lib... but looks like it might save some duplication.

The main reason for me to move TST_* variables into library is to keep code
together, where it's used.
The downside of it is that these variables may be accidentally overwritten by
setup in test. That's why I used default values, which can be overwritten in
if-lib.sh.

I'll send a patch, feel free to not ack that (agree, that it's a syntax
optimization, the test itself is what matters).

Kind regards,
Petr


More information about the ltp mailing list