[LTP] [PATCH 1/1] iptables: Reduce code duplicity

Petr Vorel pvorel@suse.cz
Thu Dec 19 19:17:33 CET 2019


Hi Alexey,

> Lgtm, except the removing of the variables, which were initializing
> with 0 (including cleanup_ ones). I know, it's very unlikely, but what
> if someone use the same name already elsewhere, then we get unexpected
> results for the test:

> # export use_iptables=1
> # nft01.sh 
> nft01 1 TINFO: timeout per run is 0h 5m 0s
> nft01 1 TINFO: INIT: Flushing all rules
> nft01 1 TINFO: iptables -L -t filter will list all rules in table filter
> nft01 1 TINFO: iptables -L -t filter lists rules

Right, this makes sense. Thanks for review, merged with variables kept.

Kind regards,
Petr


More information about the ltp mailing list