[LTP] [PATCH v1] sigpending: use direct syscall

Steve Muckle smuckle@google.com
Thu Feb 7 19:58:22 CET 2019


On 02/07/2019 07:51 AM, Matthias Maennich wrote:
> Expand coverage to the Android platform.
> 
> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---
>   testcases/kernel/syscalls/sigpending/sigpending02.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/sigpending/sigpending02.c b/testcases/kernel/syscalls/sigpending/sigpending02.c
> index a38157ae1..ff8b59c8c 100644
> --- a/testcases/kernel/syscalls/sigpending/sigpending02.c
> +++ b/testcases/kernel/syscalls/sigpending/sigpending02.c
> @@ -17,13 +17,14 @@
>   #include <sys/types.h>
>   
>   #include "tst_test.h"
> +#include "lapi/syscalls.h"
>   
>   static void run(void)
>   {
>   	/* set sigset to point to an invalid location */
>   	sigset_t *sigset = (sigset_t *) - 1;
>   
> -	TEST(sigpending(sigset));
> +	TEST(tst_syscall(__NR_rt_sigpending, sigset, NSIG / 8));
>   
>   	/* check return code */
>   	if (TST_RET == -1) {

Should this be using __NR_sigpending instead? That worked for me (for 
32-bit anyway, it's not available on arm64).

Alternately, this test/dir could be renamed to rt_sigpending, though we 
should also add a test for sigpending.

thanks,
steve



More information about the ltp mailing list