[LTP] [PATCH v2] syscalls/mprotect: align exec_func to 64 bytes

Jan Stancek jstancek@redhat.com
Mon Feb 25 08:37:50 CET 2019




----- Original Message -----
> On Tue, Feb 12, 2019 at 6:15 AM Jan Stancek <jstancek@redhat.com> wrote:
> 
> > exec_func() is dummy/empty function. Try to align it so we don't
> > need to worry about copying 2 pages. But also check that compiler
> > aligned it and there's sufficient space between start of func_exec
> > and end of page.
> >
> > This patch also removes copy_sz, which is now replaced with page_sz.
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> >
> 
> Reviewed-by: Li Wang <liwang@redhat.com>

Pushed.

Regards,
Jan

> 
> 
> > +mprotect04: CFLAGS += -falign-functions=64
> >
> 
> One of my concern was this option maybe not supported by kind of compiler
> and probably broken in the compiling phase. So I just submitted these
> two(another is Daniel's) patches to Travis CI, the result looks good and no
> compiler error found there.
> https://travis-ci.com/wangli5665/ltp/builds/101429714
> 
> Beside that, I also manually tried that with old gcc(gcc version 4.1.2) and
> verify that works fine.
> 
> --
> Regards,
> Li Wang
> 


More information about the ltp mailing list