[LTP] [PATCH 1/2] lib/tst_net.sh: don't treat TWARN/TCONF as failure in tst_netload()

Alexey Kodanev alexey.kodanev@oracle.com
Thu Feb 28 14:04:34 CET 2019


On 26.02.2019 21:26, Petr Vorel wrote:
...
>> -	if [ "$expect_ret" -ne "$ret" ]; then
>> +	if [ "$expect_ret" -ne 0 ]; then
>> +		if [ $((ret & expect_ret)) -ne 0 ]; then
>> +			tst_res_ TPASS "netstress failed as expected"
>> +		else
>> +			tst_res_ TFAIL "unexpected pass, ret is $ret"
> I like the previous one, which mentioned what was expected. maybe something
> like:
> 			tst_res_ TFAIL "unexpected pass, expected '$expect_ret', but ret: $ret"
> 
> Or even mention $expect_res, which is word (not number)?

Applied with $expect_res. Thanks for review Petr!


More information about the ltp mailing list