[LTP] [PATCH v3] cgroup_regression_test.sh ported to newlib

[Cristian Marussi]

Hi

On 04/01/2019 12:25, Petr Vorel wrote:
> Hi Cristian,
> 
>>> See diff bellow. I also added 4 commits related to this test,
>>> one of them is fixing regression I added while changing your code
>>> (I'm sorry).
> 
>> Everything's fine but in cgroup_regress_test_6_2.c you reverted to old API,
>> while you previously told me not to:
> 
>>> +++ b/testcases/kernel/controllers/cgroup/cgroup_regress_test_6_2.c
>>> @@ -0,0 +1,37 @@
>> [snip]
> 
>>> +#include <sched.h>
>>> +#include <stdlib.h>
>>> +#include <unistd.h>
>>> +#include "test.h"
>> Please don't use legacy API. <<<<<<
> 
>> is that fine ?
> 
> I'm sorry I forget to tell you I reverted this, it was deliberate change.
> Using TST_NO_DEFAULT_MAIN was wrong (it's usually used in LTP library only.
> Also it's recommended to use SAFE_*() if possible.

Oh..ok..fine I didn't know that.

> 
> I've sent patch to implement this for some C code [1], but it's failing (endless clone).
> 

I saw the patch, I'll try locally later.

> Kind regards,
> Petr

Thanks

Regards

Cristian

> 
> [1] https://patchwork.ozlabs.org/patch/1020712/
>