[LTP] [PATCH 2/2] lib/tst_test.c: Restrict that tst_brk() only works with TBROK/TCONF

Cyril Hrubis chrubis@suse.cz
Mon Jan 7 14:30:56 CET 2019


Hi!
> > Also I'm not sure if we want to convert TFAIL to TWARN inside of test
> > cleanup. And even if we wanted that change it should most likely go in
> > in a separate patch.
> Why do we need to convert TBROK to TWARN in test cleanup?  Your fix 
> patch(commit 6440c5d)
> has avoided the Infinite loop in test cleanup, so can we just keep the 
> actual result by removing
> the existed conversion?

That is just to be backward compatible with the conventions we used to
have before we allowed for SAFE_MACROS() to be used in cleanups. Before
that most of the tests were coded so that failure in cleanup produced a
warning.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list