[LTP] [PATCH v3] syscalls: Add set_mempolicy numa tests.

Cyril Hrubis chrubis@suse.cz
Wed Jan 16 13:36:21 CET 2019


Hi!
> > > I think all the alloc stuff shouldn't be in library. It's quite
> > > possible tests will need different ways to allocate memory.
> > > 
> > > Maybe the test will want to mmap, but not touch any pages,
> > > or pass different flags to mmap. Allocate with other functions
> > > than mmap, etc.
> > 
> > It should be put into some kind of common place though since it's used
> > from several tests even at this point.
> 
> set_mempolicy sub-dir?

That wouldn't not work once I will add mbind tests.

> > What about splitting the tst_numa_alloc_parse() to tst_numa_alloc() and
> > tst_numa_parse() and keeping the functionality in the library?
> 
> That looks more flexible.
> 
> Though I'm not 100% sold on single alloc func in library. My concern is
> it will be difficult for it to cover all possible scenarios and API
> will keep changing as we find more.

The worst that can happen is that we will end up with a few alloc
functions each for different purpose, but I do not think that this is
necessarily bad.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list