[LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL

Jason Xing kerneljasonxing@linux.alibaba.com
Tue Jan 29 11:13:14 CET 2019


When doing cpuset_hotplug test, it will mount cpuset filesystem on
/dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus
doesn't exist because the cgroup system generates cpus without 'cpuset'
prefix instead. The result is undoubtly TFAIL.

The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will
mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c).
The reason is that it wants the backwards compatibility for the old
cpuset file system. Therefore, using "mount -t cgroup -o" method
surely fixes this issue once for all.

Signed-off-by: Jason Xing <kerneljasonxing@linux.alibaba.com>
---
 testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
index cc31729..935a41e 100755
--- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
+++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
@@ -128,7 +128,7 @@ setup()
 
 	mkdir -p "$CPUSET_TMP"
 	mkdir "$CPUSET"
-	mount -t cpuset cpuset "$CPUSET" 2> /dev/null
+	mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
 	if [ $? -ne 0 ]; then
 		cleanup
 		tst_brkm TFAIL "Could not mount cgroup filesystem with"\
-- 
1.8.3.1



More information about the ltp mailing list