[LTP] [PATCH] syscalls/acct02.c: Read threshold from /proc/sys/kernel/acct

Xiao Yang ice_yangxiao@163.com
Tue Jul 16 16:04:17 CEST 2019


On 07/16/2019 12:00 AM, Cyril Hrubis wrote:
> Hi!
>> Don't use hardcoded threshold(default 4%) to check free space
>> because it can be changed by writing "/proc/sys/kernel/acct"
>> or using sysctl.
> Good catch, I missed the sysctl API since I haven't realized that the
> proc handlers are all stuffed in a different file in kernel/sysctl.c.
>
> What about we as well temporarily lower the value if needed while the
> test is running?
Hi Cyril,

When free space is not enough, test can change the threshold by itself
or remind user to modify the threshold by sysctl API manually.

Which one do you prefer?

Best Regards,
Xiao Yang
>




More information about the ltp mailing list