[LTP] [PATCH v6 3/3] syscalls/copy_file_range02: increase coverage and remove EXDEV test

Amir Goldstein amir73il@gmail.com
Thu Jul 25 13:02:42 CEST 2019


> > Right, sorry, missed that.
> > It is generally better not to define 1024 array on the stack.
> > Most LTP tests define test path vars as static char arrays in top of test file.
> Hi Amir
>
>   I think it is a code-style preference. IMO, 1024 array is not enough large and this function is not
> interate or recursion call.  It don't make stack overflow. Also, this test path is only used in setup().
>   So, I think keeping it is no problem.
>

Totally agree. It's a matter of coding style so up to project maintainer to
enforce it. I don't mind. Personally, I just prefer to use the code style of
the project I am contributing to.

Thanks,
Amir.


More information about the ltp mailing list