[LTP] [RFC PATCH v2 0/6] net/route: Rewrite route{4, 6}-change-{dst, gw} into C

Petr Vorel pvorel@suse.cz
Mon Jun 3 09:26:05 CEST 2019


Hi Alexey,

thanks for your comments. I suppose you don't see much point of rewriting tests
into C (and depending on libmnl). The original idea was to change it fast enough
with C to really stress it. OK, let's leave it :).

> > do_test()
> > {
> > 	local iface=$(tst_iface)
> > 	local addr new_rt

> > 	new_rt="$(tst_ipaddr_un $1)/$mask"
> > 	addr="$(tst_ipaddr_un $1 1)"

> > 	tst_res TINFO "testing route '$new_rt'"

> > 	tst_rhost_run -s -c "ip addr add $addr/$mask dev $(tst_iface rhost)"
> > 	ROD ip route add $new_rt dev $iface
> > 	ROD ip neigh replace $addr lladdr $(tst_hwaddr rhost) nud permanent dev $iface
> > > 	EXPECT_PASS ns-udpsender -f $TST_IPVER -D $addr -p $1 -o -s $udp_size

> > 	ROD ip neigh del $addr lladdr $(tst_hwaddr rhost) dev $iface
> > 	ROD ip route del $new_rt dev $iface
> > 	tst_rhost_run -c "ip addr del $addr/$mask dev $(tst_iface rhost)"

> With ns-udpsender, I think it can be without setting ip addresses:
Route over gateway requires (on IPv6) gateway on rhost, which is requires to
create this IP address first.

>  	ROD ip route add $new_rt dev $iface
>  	ROD ip neigh replace $addr lladdr $(tst_hwaddr rhost) nud permanent dev $iface
>  	EXPECT_PASS ns-udpsender -f $TST_IPVER -D $addr -p $1 -o -s $udp_size> 
> 	ROD ip neigh del $addr lladdr $(tst_hwaddr rhost) dev $iface
>  	ROD ip route del $new_rt dev $iface

> But with ping and neighbor discovery:
>  	tst_rhost_run -s -c "ip addr add $addr/$mask dev $(tst_iface rhost)"
>  	ROD ip route add $new_rt dev $iface
>  	EXPECT_PASS ping$TST_IPVER ...
>  	ROD ip route del $new_rt dev $iface
>  	tst_rhost_run -c "ip addr del $addr/$mask dev $(tst_iface rhost)"
I prefer using ping and neighbor discovery. I suppose these are both equivalent
(if not it'd be good to run them both).

Kind regards,
Petr


More information about the ltp mailing list