[LTP] [PATCH v3 3/3] syscalls/ioctl_ns0[156]: align stack and wait for child

[Cyril Hrubis]

Hi!
> > If I remember correctly at some point we decided to clean up after tests
> > properly so that we don't upset various debugging tools, i.e. coverity,
> > valgrind, etc. and I think that you were part of that discussion.
> 
> I recall I started with that position (free all), and I thought you
> turned me around after this many years :-).

Well I didn't care that much, but I guess that I lean slightly to free
the memory :-).

> Do we have anything about this in style guide? I only found brief mention 
> in "don't call cleanup from setup" section, which isn't even possible with newlib.

I don't think so. I guess that we should write something down, once we
decide what is the prefered option.

> ...
> You don't need to clean up the following:                                                                                                                                                                          
>                                                                                                                                                                                                                    
>  * +malloc(3)+'ed memory.                                                                                                                                                                                          
>  * Read-only file descriptors in persistent paths (i.e. not                                                                                                                                                        
>    temporary directories).  

Looks like this is terribly outdated, at least I tend to tell people to
close all filedescriptors to make things simpler.

-- 
Cyril Hrubis
chrubis@suse.cz