[LTP] [PATCH] syscalls: add rt_tgsigqueueinfo() test-case
Cyril Hrubis
chrubis@suse.cz
Tue Mar 5 14:29:32 CET 2019
Hi!
> It looks like the pthread here is sending the signal to itself which
> seems like a special case. Not that it isn't worth testing but I'd think
> there should be a test which sends the signal to a different thread.
> This (the self-send case) could be an additional test.
>
> > + if (TST_RET)
> > + tst_res(TFAIL, "Test Failed");
> > + else
> > + tst_res(TPASS, "Test Succeeded");
>
> I recommend verifying the signal and its data (si_value) are delivered
> successfully prior to test completion.
Agreed.
Also we do have rt_sigqueueinfo01.c tests that lacks these checks as
well, it may be a good idea to rewrite that test as well, quite possibly
some code could be shared between these two as well.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list