[LTP] [PATCH/RFC] syscalls/readahead02: don't use cache size

[Amir Goldstein]

On Tue, Mar 5, 2019 at 2:34 PM Jan Stancek <jstancek@redhat.com> wrote:
>
> Using system-wide "Cached" size is not accurate. The test is sporadically
> failing with warning on ppc64le 4.18 and 5.0 kernels.
>
> Problem is that test over-estimates max readahead size, which then
> leads to fewer readhead calls and kernel can silently trims length
> in each of them:
>   ...
>   readahead02.c:244: INFO: Test #2: POSIX_FADV_WILLNEED on file
>   readahead02.c:134: INFO: creating test file of size: 67108864
>   readahead02.c:263: INFO: read_testfile(0)
>   readahead02.c:274: INFO: read_testfile(1)
>   readahead02.c:189: INFO: max ra estimate: 12320768
>   readahead02.c:198: INFO: readahead calls made: 6
>   readahead02.c:204: PASS: offset is still at 0 as expected
>   readahead02.c:308: INFO: read_testfile(0) took: 492486 usec
>   readahead02.c:309: INFO: read_testfile(1) took: 430627 usec
>   readahead02.c:311: INFO: read_testfile(0) read: 67108864 bytes
>   readahead02.c:313: INFO: read_testfile(1) read: 59244544 bytes
>   readahead02.c:316: PASS: readahead saved some I/O
>   readahead02.c:324: INFO: cache can hold at least: 264192 kB
>   readahead02.c:325: INFO: read_testfile(0) used cache: 124992 kB
>   readahead02.c:326: INFO: read_testfile(1) used cache: 12032 kB
>   readahead02.c:338: WARN: using less cache than expected
>
> Stop relying on used cache size, and use minimal sane readahead length,
> that should work across all systems.

But now instead of over estimating readahead length you definetly
underestimate it resulting in way too many readahead calls
(reahead every 4K block), which does not validate long readahead
code is working at all.

How about this patch instead.
Can you say with sufficient confidence if it solves the sporadic errors?
Also, IMO if you solve the estimation problem, there is no need to
remove the WARNING, it may still be informative.

Thanks,
Amir.

--- a/testcases/kernel/syscalls/readahead/readahead02.c
+++ b/testcases/kernel/syscalls/readahead/readahead02.c
@@ -50,6 +50,8 @@ static int ovl_mounted;
 #define OVL_WORK       MNTPOINT"/work"
 #define OVL_MNT                MNTPOINT"/ovl"
 #define MIN_SANE_READAHEAD (4u * 1024u)
+/* To avoid over estimation of readahead length */
+#define MAX_SANE_READAHEAD (1024u * 1024u)

 static const char mntpoint[] = MNTPOINT;

@@ -193,7 +195,7 @@ static int read_testfile(struct tcase *tc, int do_readahead,
                        }

                        i++;
-                       offset += max_ra_estimate;
+                       offset += MIN(max_ra_estimate, MAX_SANE_READAHEAD);
                } while ((size_t)offset < fsize);
                tst_res(TINFO, "readahead calls made: %zu", i);
                *cached = get_cached_size();