[LTP] [PATCH] setpriority01: Skip only PRIO_USER when unable to add test user
Mon Mar 11 19:23:52 CET 2019
On Mon, Mar 11, 2019 at 9:05 AM Cyril Hrubis <firstname.lastname@example.org> wrote:
> > > But is the test that's broken if useradd fails for wherever reason?
> > > it a configuration issue?
> > >
> > >
> > Looking more into the definition of TBROK, TCONF and the code before my
> > changes:
> > - if (eaccess("/etc/passwd", W_OK))
> > - tst_brk(TCONF, "/etc/passwd is not accessible");
> > -
> > - tst_run_cmd(cmd_useradd, NULL, NULL, 0);
> > - user_added = 1;
> > -
> > Should an eaccess write failure have resulted in a TCONF? Shouldn't that
> > have been a TBROK too?
> Looking at the git log this seems to be handling very specific case
> where the rootfs is read only, quite likely this test was failing on
> some specific embedded hardware. As far as I can tell this sounds like a
> reasonable solution to the problem.
> > I'm fine with whatever way we go, except not wanting to fail the entire
> > test case just because useradd isn't present in android. It's still very
> > useful to run the other setpriority tests.
> Sounds good, there is no point not to map missing useradd to TCONF, I
> just want to avoid mapping segfaulting or otherwise faulty useradd to
> TCONF as well.
Thanks for the reviews and comments! I sent out a v2 patch that addressed
your concerns. Can you please take a look at that and accept or suggest
changes to it? In that patch, I treated the "no write permissions to
/etc/passwd" as a TBROK and not TCONF as that seemed more appropriate to
me. But if you want I can map that back to TCONF -- according to man pages,
useradd has an error code for not being able to write to /etc/passwd.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the ltp