[LTP] [PATCH v2 1/4] shell: Add tst_mount() helper

Petr Vorel pvorel@suse.cz
Thu Mar 14 14:27:01 CET 2019


Hi Cyril,

> The last nit is this piece of docummentation.

> - The last sentence is missing subject, generally the sentence does not
>   make much sense
> - We should document that TST_MNTPOINT defaults to mntpoint

> So it should be something as:

> The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to
> '$TST_MNTPOINT' (defaults to mntpoint), optionally using the
> '$TST_MNT_PARAMS'. The '$TST_MNTPOINT' directory is created if it didn't
> exist prior to the function call.


> Otherwise it all looks fine, acked with a change to this docs.

Thank for fixes, merged!


Kind regards,
Petr


More information about the ltp mailing list