[LTP] [PATCH v2 1/3] syscalls/tgkill01: add new test

[Li Wang]

On Fri, Mar 15, 2019 at 6:09 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > >>  int tst_checkpoint_wait(unsigned int id, unsigned int msec_timeout)
> > >>  {
> > >>         struct timespec timeout;
> > >> +       int ret;
> > >>
> > >>         if (id >= tst_max_futexes) {
> > >>                 errno = EOVERFLOW;
> > >> @@ -94,8 +95,12 @@ int tst_checkpoint_wait(unsigned int id, unsigned
> int msec_timeout)
> > >>         timeout.tv_sec = msec_timeout/1000;
> > >>         timeout.tv_nsec = (msec_timeout%1000) * 1000000;
> > >>
> > >> -       return syscall(SYS_futex, &tst_futexes[id], FUTEX_WAIT,
> > >> -                      tst_futexes[id], &timeout);
> > >> +       do {
> > >> +               ret = syscall(SYS_futex, &tst_futexes[id], FUTEX_WAIT,
> > >> +                             tst_futexes[id], &timeout);
> > >
> > >     if (ret == -1 && errno == EINTR)
> > >         tst_res(TWARN | TERRNO, "FUTEX_WAIT operation was interrupted
> by a signal, retry again");
> > >
> >
> > I am not sure if this warning message is desired for test-cases which
> > needs to wait on checkpoints irrespective of signals like this
> > tgkill01 test-case.
>
> Agreed, it's not an error condition, it's just a coincidence that most
> of the tests does not get signals when they sleep on futex, otherwise
> thing would crash and burn. So I would argue that retrying on EINTR is
> actually a bug fix rather than anything else.
>

Okay, here I'm not insist to print the warning. But it's only use for hint
on that worst situation which you were mentioned. If the checkpoint got
signal leads to never timeout and test eventually killed by test lib. That
would hard to know what happened at that moment. My concern is the
situation is hard to reproduce later so just want to print more useful
messeges:).

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20190315/5caa91e0/attachment-0001.html>