[LTP] [PATCH v2] setpriority01: Skip only PRIO_USER when unable to add test user

Petr Vorel pvorel@suse.cz
Tue Mar 19 09:32:10 CET 2019

Hi Saravana,

> We don't need to skip all the tests just because we are unable to add
> a test user. Not having a test user only affects PRIO_USER test case.
> So just skip that one and continue running the rest of the tests when
> useradd is not available.

> If useradd is present and it still fails, then consider it an error in
> the test preparation phase.

> This also allows this test case to be built and run on Android.

> Signed-off-by: Saravana Kannan <saravanak@google.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>

> v2:
> - Skip only PRIO_USER test when useradd isn't present
> - Fail entire test with TBROK for all other cases where user can't be added

> I still think v1 is the right approach. But if you want TCONF for only
> for cases like Android where useradd itself isn't present, then v2 would
> be the right patch.
Agree with it, but waiting for Cyril approval to merge it.

Kind regards,

More information about the ltp mailing list