[LTP] [ltp][PATCH v3] Add ltp pivot_root test

Cyril Hrubis chrubis@suse.cz
Tue Mar 19 16:45:12 CET 2019


Hi!
> > +#else
> > +static void run(void)
> > +{
> > +	tst_brk(TCONF, NULL, "unshare is undefined.");
> Here NULL is copy paste error (that cleanup parameter is from legacy API, here
> suppress the message).
> We use TST_TEST_TCONF for cases like this.
> + Please guard everything, otherwise we get "defined but not used".

That is what I was going to suggest guard the whole test into #ifdef for
libcap and unshare, there is no point in doing anything else if the test
cannot run without these.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list