[LTP] [PATCH v3 1/2] tst_test: Add test multiplex function

Petr Vorel pvorel@suse.cz
Mon Mar 25 10:50:54 CET 2019

Hi Cyril,

Nice! Whole patchset LGTM, one typo below.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

> +2.2.29 Testing similar syscalls in one test
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +In some cases kernel has several very similar syscalls that do either the same
> +or very similar job. This is most noticeable on i386 where we commonly have
> +two or three syscall versions. That is because i386 was first platform that
> +Linux was developed on and because of that most mistakes in API happened there
> +as well. However this is not limited to i386 at all, it's quite common that
> +version two syscall has added missing flags parameters or so.
> +
> +In such cases it does not make much sense to copy&paste the test code over and
> +over, rather than that the test library provides support for test variants.
> +The idea behind test variants is simple, we run the test several times each
> +time with different syscall variant.
> +
> +The implemenation consist of test_variant integer that, if set, denotes number
Typo => implementation

Kind regards,

More information about the ltp mailing list