[LTP] [PATCH v2] syscalls/preadv203: Add basic RWF_NOWAIT test

Amir Goldstein amir73il@gmail.com
Mon May 20 12:30:27 CEST 2019


On Mon, May 20, 2019 at 1:08 PM Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> Ping, anybody has any comments or can be this be this merged?
>

I have no objection to this test, but I have a question. Your claim is:
"We are attempting to trigger the EAGAIN path for the RWF_NOWAIT flag."

Seems like you have gone to a great length of effort to achieve this.
Wouldn't it be sufficient to do a single preadv2 after fsync+drop_caches in
order to observe EAGAIN?

There are several other ways to get EAGAIN, like DIO read/write when
page cache *is* populated.

Question is, how much is the test trying to cover.

Thanks,
Amir.


More information about the ltp mailing list