[LTP] [PATCH 1/2] lib/tst_test: introduce tst_test->some_filesystems

Murphy Zhou xzhou@redhat.com
Thu May 30 17:02:35 CEST 2019


On Thu, May 30, 2019 at 12:51:40PM +0200, Cyril Hrubis wrote:
> Hi!
> > Like all_filesystems, some_filesystems option let tcase to run on
> > specific filesystems.
> > In order to implement this, change run_tcases_per_fs to accept a
> > parameter indicating which filesystems need to test.
> > 
> > To let tcase use this option, we need some other flags set
> > Eg:
> > static char *some_filesystems[] = {"ext4", "xfs", "btrfs"};
> > 
> >   .mount_device = 0,
> >   .needs_device = 1,
> >   .format_device = 1,
> >   .mntpoint = MNTPOINT,
> >   .some_filesystems = some_filesystems,
> 
> Can't we just change the dev_fs_type to dev_fs_types array instead?

Sure. That's a much better name! My naming taste needs much improvement...

Thanks!

> 
> -- 
> Cyril Hrubis
> chrubis@suse.cz


More information about the ltp mailing list