[LTP] [PATCH v3 2/5] syscalls/quotactl02.c: Add Q_XGETQSTATV test

[Petr Vorel]

Hi Xu,

> Q_XGETQSTATV returns XFS filesystem-specific quota information in the fs_quota_statv
> pointed to by addr. The qs_version field of the structure should be filled with
> the version of the structure supported by the caller (for now, only FS_QSTAT_VERSION1
> is supported).
nit: one would think you add 1 test case. But you added 8 test cases, all of
them are XFS related, but only 4 related to Q_XGETQSTATV.

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Nice work, thanks!

Nit: I'd just extract quotactl02.h later in the commit, where
the code needs to be reused (i.e. in 0cc1dc512 ("syscalls/quotactl05: add
project quota test for xfs filesystem")) or at least mention why you do it now.

...
> +++ b/testcases/kernel/syscalls/quotactl/quotactl02.c
...
> +#if defined(HAVE_STRUCT_FS_QUOTA_STATV)
> +	{QCMD(Q_XQUOTAOFF, GRPQUOTA), &qflagg, check_qoffv,
> +	QCMD(Q_XGETQSTATV, GRPQUOTA), 1,
> +	"turn off xfs quota and get xfs quota off statv for group"},

> -	tst_res(TPASS, "quoactl() succeeded to set and use %s to get xfs disk quota limits",
> -			desp);
> -}
> +	{QCMD(Q_XQUOTAON, GRPQUOTA), &qflagg, check_qonv,
> +	QCMD(Q_XGETQSTATV, GRPQUOTA), 1,
> +	"turn on xfs quota and get xfs quota on statv for group"},
> +#endif
> +};
Hm, we don't report some TCONF: Q_XGETQSTATV not supported.
But that's probably not important.

...

Kind regards,
Petr