[LTP] [PATCH 1/1] fanotify: Fix for musl

Petr Vorel petr.vorel@gmail.com
Sun Nov 17 11:04:01 CET 2019


Hi Jan,

> ----- Original Message -----
> > FSID_VAL_MEMBER() wrapper was meant to be only for struct
> > fanotify_event_info_fid, it was used also for struct event_t
> > (which has also __kernel_fsid_t fsid, but shouldn't be redefined).

> > This caused error on recent musl v1.1.23 (with f67b3c17),
> > which has struct fanotify_event_info_fid.

> > Fixes: 0498fc0a8 ("fanotify: Detect val vs. __val
> > fanotify_event_info_fid.fsid member")

> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>

> If it's needed for __kernel_fsid_t we'll need to come up with better names.
+1. But hope this is not needed.

> This basically reverts part of previous patch, which looks ok to me.
Yep. I'll add this to commit message, to be obvious.

> Acked-by: Jan Stancek <jstancek@redhat.com>

Thanks for your review.
I'll wait with merge till Monday (if Cyril has some comments).

Kind regards,
Petr


More information about the ltp mailing list