[LTP] [PATCH] tst_fill_fs: enhance the filesystem filling routine

[Martin Doucha]

On 11/19/19 3:03 PM, Li Wang wrote:
> On Tue, Nov 19, 2019 at 7:07 PM Jan Stancek <jstancek@redhat.com
> <mailto:jstancek@redhat.com>> wrote:
> 
>     ----- Original Message -----
>     > -             while (len) {
>     > +             while (len >= fi.f_bsize) {
> 
>     Let's say f_bsize is 512, and len is 1023. We hit ENOSPC for 1023,
>     len for next round is 511. Loop ends, but we never tried write with
>     f_bsize or smaller value.
> 
>     I think we should try len < fi.f_bsize at least once.
> 
> 
> Good point. At least for len = fi.f_bsize.

You don't need to reduce the write size in the first place. Kernel will
happily do short writes for you if the file system somehow finds some
free blocks. The more important question is how to trigger garbage
collection of internal file system book-keeping data.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic