[LTP] [PATCH 2/2] tst_test.sh: Add public tst_test_root command

Cyril Hrubis chrubis@suse.cz
Wed Oct 9 13:48:54 CEST 2019


Hi!
> > Can we keep the name to be tst_require_root() please?
> >
> > Historically this function has been always named like this in LTP.
> >
> Not a very good argument for two reasons:
> 1. The function was internal to the library, so no one (except for 
> library developers)

It has been in a public API for the old library for more than ten years
before the new library was written.

> 2. I wanted to make it consistent with other functions, that do similar 
> stuff like
>  ???? tst_test_drivers and tst_test_cmds. Both also call tst_brk in case 
> of unsuccessful tests.

Well I do not like these names either, it's less descriptive that it
would have been with tst_require_cmds and tst_require_drivers, so if
anything I would be for renaming the tst_test_* ones.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list