[LTP] [PATCH v2] acct: fix version check on big endian system

[Li Wang]

Ping Fang <pifang@redhat.com> wrote:

ac_version = ACCT_VERION | ACCT_BYTEORDER
> which is 0x83 (131) on big endian system.
>
> failure output:
> tst_kconfig.c:62: INFO: Parsing kernel config
> '/boot/config-4.18.0-147.el8.s390x'
> tst_test.c:1118: INFO: Timeout per run is 0h 05m 00s
> tst_kconfig.c:62: INFO: Parsing kernel config
> '/boot/config-4.18.0-147.el8.s390x'
> acct02.c:239: INFO: Verifying using 'struct acct_v3'
> acct02.c:192: INFO: == entry 1 ==
> acct02.c:147: INFO: ac_version != 3 (131)
> acct02.c:192: INFO: == entry 2 ==
> acct02.c:82: INFO: ac_comm != 'acct02_helper' ('acct02')
> acct02.c:133: INFO: ac_exitcode != 32768 (0)
> acct02.c:141: INFO: ac_ppid != 34501 (34500)
> acct02.c:147: INFO: ac_version != 3 (131)
> acct02.c:182: FAIL: end of file reached
>

I'm wondering that is there any necessary to use do{}...while loop for
entry many times? Since the verify_acct() only check the dummy
program(acct02_helper) accounting struct. So in the error logs, we could
see some meaningless data(acct02) in entry 2.

    acct02.c:192: INFO: == entry 2 ==
    acct02.c:82: INFO: ac_comm != 'acct02_helper' ('acct02')
    acct02.c:133: INFO: ac_exitcode != 32768 (0)
    acct02.c:141: INFO: ac_ppid != 34501 (34500)

This needs to be fixed in a separate patch.


> Signed-off-by: Ping Fang <pifang@redhat.com>
>

The patch itself looks good. Ack.

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20191010/8384c718/attachment.htm>