[LTP] [RFC PATCH] tst_taint: TCONF when kernel is alreay tainted

[Jan Stancek]

----- Original Message -----
> Hi!
> > As the tst_taint_init comments described, If the tainted-flags are already
> > set
> > by the kernel, there is no reason to continue and TCONF is generated. But
> > in
> > the function achieve, it uses TBROK.
> > 
> >   cmdline="cve-2017-17053"
> >   tst_test.c:1096: INFO: Timeout per run is 0h 10m 00s
> >   tst_taint.c:88: BROK: Kernel is already tainted: 536871424
> 
> There is a reason for generating TBROK, we do not want the test to be
> skipped silently in this case.

It can still run and maybe trigger worse problem. IMO if test wants
to report taint flags it should only report _new_ taint flags.

We could add a dummy test to end of runtest file, which would check
selected taint flags and report WARN/FAIL, so they are guaranteed
to appear on report.

Regards,
Jan