[LTP] [PATCH 2/2] testcases/kernel: Add linux git and CVE tags

Petr Vorel pvorel@suse.cz
Wed Oct 16 15:21:39 CEST 2019


Hi,

> > > +       .tags = (const struct tst_tag[]) {
> > > +               {"linux-git", "4291086b1f08"},
> > > +               {"CVE", "2014-0196"},
> > > +               {}

> > Some of the tests use {NULL, NULL} to terminate tag array but some not,
> > maybe we need to keep consistent in usage.

> I guess I missed some when I was converting {NULL, NULL} to just {}. I
> will fix that in v2.
+1

Nice work, thanks :).
Reviewed-by: Petr Vorel <pvorel@suse.cz>

nit: I don't that much blank lines, I'd prefer more compact output:

OPTIONS
-h       Prints this help
-i n     Execute test n times
-I x     Execute test for n seconds
-C ARG   Run child process with ARG arguments (used internally)

TAGS
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c461cb727d1
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-2618

Kind regards,
Petr


More information about the ltp mailing list