[LTP] Bug report in read_all.c

Richard Palethorpe rpalethorpe@suse.de
Wed Oct 23 10:11:47 CEST 2019


Xiang Li <lixian@qti.qualcomm.com> writes:

> Hi,
> Thanks for Richard's suggestion. I've put it in the patch.
> Please check the attached patch file for review.

Thanks, LGTM.

However please do not send patches as attachments; we like to respond
with review comments inline.

> Regards,
> Xiang
> -----Original Message-----
> From: Cyril Hrubis <chrubis@suse.cz> 
> Sent: Tuesday, October 22, 2019 8:12 PM
> To: Xiang Li <lixian@qti.qualcomm.com>
> Cc: ltp@lists.linux.it
> Subject: [EXT] Re: [LTP] Bug report in read_all.c
> Hi!
>> Modifying i + 1 to (i + 1) % QUEUE_SIZE at the source code Line#123 can easily fix it.
>> This bug is not triggered on every machine because the files are different between target machine.
>> Adjust the length of the QUEUE_SIZE will help you reproduce this bug.
> Can you send a patch that I can apply (ideally with the suggestion from Ritchie as well)?

Thank you,

More information about the ltp mailing list