[LTP] [PATCH v2 2/3] shell: Introduce TST_TIMEOUT variable

Clemens Famulla-Conrad cfamullaconrad@suse.de
Wed Sep 18 19:19:36 CEST 2019


On Wed, 2019-09-18 at 15:53 +0200, Petr Vorel wrote:
> Hi Li,
> 
> > > > If the $LTP_TIMEOUT_MUL is float and awk command is missing,
> > > > how things
> > > > will be going?
> > > > It will break at:
> > > >     tst_test_cmds awk
> > > > right?
> > > 
> > > Yes. The concern is described in the commit message (but it
> > > should also be
> > > in
> > > wiki page I guess): you want float => you need awk. You don't
> > > have float,
> > > just
> > > set it as int (which will affect also C).
> > > Does it make sense? Is it useful?
> 
> 
> > It's working, but not elegant. Not sure how many people will go
> > through the
> > documents for such tiny issues.
> > Is there any possibility to handle float by default, and if no awk
> > supporting, just round up the float to integer and use it do
> > testing
> > automatically?
> 
> Yep, that's better idea, thanks!
> I'll print some info in case of forcing to round to int in v3.

I like this idea, too.



More information about the ltp mailing list