[LTP] [PATCH v2] add_key05: Avoid race with key garbage collection

[Jan Stancek]

----- Original Message -----
> --- a/testcases/kernel/syscalls/add_key/add_key05.c
> +++ b/testcases/kernel/syscalls/add_key/add_key05.c
> @@ -10,6 +10,10 @@
>   * This is also a regression test for
>   * commit a08bf91ce28e ("KEYS: allow reaching the keys quotas exactly")
>   * commit 2e356101e72a ("KEYS: reaching the keys quotas correctly")
> + *
> + * If you run this test with -i > 10 then expect to see some sporadic
> failures

Since test is using 2 users per iteration, should above say -i > 5?

> + * where add_key fails with EDQUOT. Keys are freed asynchronously and we
> only
> + * create up to 10 users to avoid race conditions.
>   */
>  
>  #include <stdio.h>
> @@ -18,47 +22,53 @@
>  #include "tst_test.h"
>  #include "lapi/keyctl.h"
>  
> +#define MAX_USERS 10
> +
>  static char *user_buf;
> -static const char *username = "ltp_add_key05";
> -static int user_added;
> -struct passwd *ltpuser;
> -static char fmt[1024];
> +static uid_t ltpuser[MAX_USERS];
> +
> +static unsigned int usern;
> +static volatile unsigned int useri;

I don't see why volatile is needed here. Other than that rest looks
reasonable to me. 

Acked-by: Jan Stancek <jstancek@redhat.com>